This repository was archived by the owner on Aug 7, 2021. It is now read-only.
feat: NativeScript bootstrap transformer #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sis0k0
suggested changes
Aug 15, 2018
templates/webpack.angular.js
Outdated
| @@ -3,6 +3,7 @@ const { join, relative, resolve, sep } = require("path"); | |||
| const webpack = require("webpack"); | |||
| const nsWebpack = require("nativescript-dev-webpack"); | |||
| const nativescriptTarget = require("nativescript-dev-webpack/nativescript-target"); | |||
| const { nsReplaceBootstrap } = require("nativescript-dev-webpack/plugins/ns-replace-bootstrap"); | |||
There was a problem hiding this comment.
Can you reexport that from the index file?
| const entryModule = aot ? | ||
| nsWebpack.getAotEntryModule(appFullPath) : | ||
| `${nsWebpack.getEntryModule(appFullPath)}.ts`; | ||
| const entryModule = `${nsWebpack.getEntryModule(appFullPath)}.ts`; |
There was a problem hiding this comment.
Please remove the getAotEntryModule function from index.js as well.
There was a problem hiding this comment.
It's a breaking change if we remove it completely.
There was a problem hiding this comment.
Yep. We discussed to introduce a Deprecated decorator in another PR.
templates/webpack.angular.js
Outdated
| const ngCompilerPlugin = new AngularCompilerPlugin({ | ||
| hostReplacementPaths: nsWebpack.getResolver([platform, "tns"]), | ||
| platformTransformers: aot ? [nsReplaceBootstrap(() => ngCompilerPlugin)] : null, | ||
| mainPath: resolve(appPath, "main.ts"), |
There was a problem hiding this comment.
oops, that's from a previous PR (mine ;d), but I think it should be mainPath: entryModule instead of hardcoded to main.ts.
tsconfig.json
Outdated
| @@ -10,6 +10,7 @@ | |||
| "files": [ | |||
| "plugins/PlatformFSPlugin.ts", | |||
| "plugins/WatchStateLoggerPlugin.ts", | |||
| "plugins/ns-replace-bootstrap.ts", | |||
There was a problem hiding this comment.
mm, that's not really a webpack plugin. Can we move it to a transformers folder or something like that.
vakrilov
changed the title
The bootstrap transformer will automatically replace the platform and bootstrap calls inside `main.ts` when building with AOT. This will eliminate the need for `main.aot.ts` and `app.module.ngfactory.d.ts` files in templates.
This won't work for projects that don't have dependency for `@ngtools/webpack`.
sis0k0
force-pushed
the
replace-bootstrap
branch
from
e65d008 to
c3a3b0b
Compare
sis0k0
approved these changes
Aug 17, 2018
sis0k0
added a commit
that referenced
this pull request
Aug 28, 2018
It was removed (probably accidentally) in #634.
sis0k0
added a commit
that referenced
this pull request
Aug 31, 2018
It was removed (probably accidentally) in #634.
sis0k0
added a commit
that referenced
this pull request
Sep 10, 2018
<a name="0.16.0"></a> # [0.16.0](0.15.1...0.16.0) (2018-09-10) ### Features * NativeScript bootstrap transformer ([#634](#634)) ([c016418](c016418))
manoldonev
pushed a commit
to NativeScript/nativescript-app-templates
that referenced
this pull request
Jan 9, 2019
They won't be needed with {N}-dev-webpack 0.16.0, because of this change
- NativeScript/nativescript-dev-webpack#634.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bootstrap transformer will automatically replace the platform and bootstrap calls inside
main.tswhen building with AOT.This will eliminate the need for
main.aot.tsandapp.module.ngfactory.d.tsfiles in templates.This depends on angular/angular-cli#11786 going public